bump to rc.3 once released
bacongobbler opened this issue · 7 comments
helm/helm#6866 introduced a breaking change to the storage backend which will affect how 2to3 creates releases. A larger explanation/justification for the breaking change was provided in helm/helm#6881 (comment). The 2to3 plugin should cut a new release compiled against Helm 3.0.0-rc.3 once it's been released later today to be compatible with Helm 3.0.0.
sure
@bacongobbler This is should not be a breaking change for the plugin. No changes are required.
FYI, we would always update to the latest release of Helm 3 in any case.
I will update once RC-3 is released.
The call to cfg.Releases.Create on line 97 may migrate a Helm 2 release as the older Helm 3 metadata. That might not be compatible with Helm 3.0. I'll have to check and confirm just to be 100% sure, but in any case I wanted to reach out. In either case, updating to rc.3 will remove any doubts :)
It was identified from helm/helm#6881 (comment) that this may not actually be a backwards-incompatible change. Phew!
In middle of something at moment but will try and get to it shortly. Off hand, should be ok. Will check shortly. Thanks for reaching out @bacongobbler
@bacongobbler Following testing, it works as expected. This is because the plugin interfaces with the Helm object field name definitions and not the persisted object field names. It would only be affected if the Helm object definitions changed and/or relevant API changed.