helmfile/helmfile

`helmfile diff` doesn't pass `--args` to `helm diff`

dvarrazzo opened this issue · 1 comments

Operating system

Ubuntu 22.04

Helmfile Version

0.158.1

Helm Version

3.12.3

Bug description

Running helmfile diff --args "--normalize-manifests" the args are not passed to helm diff.

Regression from 0.157.0, probably around fixing #1095.

$ helmfile-0.157.0 diff --args "--normalize-manifests" --debug 2>&1 > /dev/null | grep 'helm diff'
exec: helm diff upgrade --allow-unreleased akv2k8s spvapi/akv2k8s --version 2.3.2 --namespace default --reset-values --normalize-manifests --debug

$ helmfile-0.158.1 diff --args "--normalize-manifests" --debug 2>&1 > /dev/null | grep 'helm diff'
exec: helm diff upgrade --allow-unreleased akv2k8s spvapi/akv2k8s --version 2.3.2 --namespace default --reset-values

helmfile diff --diff-args seems not affected:

$ helmfile-0.157.0 diff --diff-args "--normalize-manifests" --debug 2>&1 > /dev/null | grep 'helm diff'
exec: helm diff upgrade --allow-unreleased akv2k8s spvapi/akv2k8s --version 2.3.2 --namespace default --reset-values --debug --normalize-manifests

$ helmfile-0.158.1 diff --diff-args "--normalize-manifests" --debug 2>&1 > /dev/null | grep 'helm diff'
exec: helm diff upgrade --allow-unreleased akv2k8s spvapi/akv2k8s --version 2.3.2 --normalize-manifests --namespace default --reset-values

(I see a difference in --debug not being passed to the diff in 0.158.1, I don't know if that's expected or not).

Example helmfile.yaml

releases:
  - name: akv2k8s
    namespace: default
    chart: spvapi/akv2k8s
    version: 2.3.2
    installed: true
  
repositories:
  - name: spvapi
    url: https://charts.spvapi.no

Error message you've seen (if any)

No error message.

Steps to reproduce

See above.

Working Helmfile Version

0.157.0

Relevant discussion

No response

@dvarrazzo please try use main branch.