henomis/lingoose

Require Pointer Type

Closed this issue · 5 comments

Lenstack commented

lingoose/llm/openai/openai.go

Line 346 in 7ea0cd0

Function: openai.FunctionDefinition{

Captura de pantalla 2024-03-21 165857
imagen

Lenstack commented

We could use Type: openai.AssistantToolTypeFunction, Function: &openai.FunctionDefinition{}

henomis commented

@Lenstack I don't understand your issue. Please check imports and be sure to alias lingoose's openai to avoid conflicts with the go openai package.

Lenstack commented

@henomis Internally, lingoose uses "github.com/sashabaranov/go-openai". Therefore, in the implementation of getChatCompletionRequestTools, when using openai.FunctionDefinition{}, it requires to be called as &openai.FunctionDefinition{} because "FunctionDefinition" is a pointer.

henomis commented

@Lenstack Lingoose uses v1.19.2 of the go-openai package. In this version FunctionDefinition is not a pointer.
If it had been a pointer the code would give compiling errors. Your PR is broken, indeed.

henomis commented

As there's been no follow-up on the requested changes, I'm closing this issue.