heraldofsolace/VimHelpBot

v_CTRL-] response uses invalid old reddit markdown

Closed this issue · 3 comments

idbrii commented

Describe the bug
Response for v_CTRL-] help uses invalid old reddit markdown -- the ] needs to be escaped.

To Reproduce
Enter this input

See `:h v_CTRL-]`.

See example:

Broken in old
But works in new

Expected Output

Help pages for:

* [v_CTRL-\]](https://vimhelp.org/tagsrch.txt.html#v_CTRL-%5D) in _tagsrch.txt_

(not using fixed width since it doesn't let you escape ] in old reddit.

Actual Output

Help pages for:

* [`v_CTRL-]`](https://vimhelp.org/tagsrch.txt.html#v_CTRL-%5D) in _tagsrch.txt_

Additional context

  • Willing to take up?
heraldofsolace commented

Thanks for reporting this issue. Do you know of any other texts that could potentially be problematic?

idbrii commented

Presumably anything with ] and possibly with [, but I'm not sure. This is the first time I've seen a malformed link from VimHelpBot.

:help ]<Tab> shows a bunch of other help topics containint ]. I think you'd have to process :help index to convert them into links for testing VimHelpBot. Not sure where you can do testing without spamming /r/vim.

heraldofsolace commented

This is fixed now

  • 🎉1