heremaps/harp.gl

Shadows are turned on, but shadows are not displayed on the map tiles.

Closed this issue · 8 comments

datouzhan commented

Is your feature request related to a problem? Please describe.
I have configured the theme json
image
And set the light.Shadows are turned on, but shadows are not displayed on the map tiles.
image

Describe the solution you'd like
image
shadows are displayed on the map tiles.

FraukeF commented

Hi @datouzhan,

did you enable the shadows in MapView too, something like:
map = new MapView({ canvas, theme, enableShadows: true });

This is needed to enable the shadow on the map materials too.

Let me know if this helps.

Frauke

datouzhan commented

Yes,I've already set it enable.But it didn't help.The map loaded is WebTileDataSource. if it has anything to do with this.

FraukeF commented

ah sorry, I should have seen that from the screenshot probably, ... it will only work with a VectorTileDataSource below

datouzhan commented

This is really sad news. if I want the map tiles to also show shadows, do I need to expand it?

FraukeF commented

Hi, I just checked, whats actually missing to make it work... I created some draft PR so you can try it out https://github.com/heremaps/harp.gl/pull/2125/files .. I ll try to polish it later and push it to master

  • 🚀1
datouzhan commented

I'm glad to hear that. @FraukeF , When will the next version be built?

nzjony commented

@datouzhan , @FraukeF has a merged PR: #2125 which fixes the issue.

We will do a release in the next week, so stay tuned.

nzjony commented

Closing because this is now released.