herodevs/herodevs-packages

Fails to compile with Angular 8

wmaurer opened this issue · 8 comments

wmaurer commented

The InternalNgModuleRef interface is no longer exported from @angular/core.
The best solution I can think of is to redefine InternalNgModuleRef in dynamic-component.service.ts

sujitgawas19 commented

Angular 8 prod build fails with following error : ERROR in node_modules/@herodevs/dynamic-af/lib/dynamic-af.service.d.ts(2,37): error TS2307: Cannot find module '@angular/core/src/linker/ng_module_factory'.

giampierobono commented

Any news about this?

wmaurer commented

It seems to have been merged, but not yet published to npm.
@aaronfrost could you please publish?

aaronfrost commented

I thought I published 2.0.1 to NPM. Are you sure? @wmaurer

wmaurer commented

@aaronfrost sorry, my fault. Somehow I've been using lazy-af and not hero-loader. Rather confusing. Maybe the lazy-af package should have a deprecation notice ... ;-)

aaronfrost commented

@wmaurer I think that most people are still using lazy-af. I need to push a deprecated message to lazy-af so that people can see it and switch to hero-loader.

wmaurer commented

Please do, I think that would make a lot of sense.

jindovu commented

any update on this one, I still got this issue, please help