heroku/vegur

The Via header isn't added on error pages

ferd opened this issue · 2 comments

ferd commented

Particularly, a response invalidated for a reason such as invalid content-length will see its response of the form:

HTTP/1.1 502 Bad Gateway
Connection: keep-alive
Server: Cowboy
Date: Thu, 02 Oct 2014 19:45:23 GMT
Content-Length: 484
Content-Type: text/html; charset=utf-8
Cache-Control: no-cache, no-store

....

Which shows no via header.

Does Via belong on error pages? Lets see The Spec

The Via general-header field MUST be used by gateways and proxies to indicate the intermediate protocols and recipients between the user agent and the server on requests, and between the origin server and the client on responses.

These requests were never proxied to the backend. I'm being pedantic..or what?

ferd commented

That's an interesting interpretation and I have no counter-argument, even if it's pedantic. The entire spec implementation is pedantry. But we are still not the intended end-server so I'm not sure.