heronsilva/firefox-theme-vscode

Missing link and inline code styles in Markdown Preview

Closed this issue · 1 comments

metamas commented

Link and inline code style aren't differentiated from plain text in Firefox Dark when viewing a Markdown Preview.

A link's style is only visibly different from plain text if you hover over it. Then it matches the Firefox Dark (Classic) style.

The inline code is monospace, but still difficult to spot without any other style difference.

I've looked at dark.yml, and it does appear that differnt text colors have not been set for these elements. I've just forked and fixed them to match the settings for Dark (Classic). I will submit a PR now.

Light:
image

Dark
image

Dark (Classic)
image

heronsilva commented

Hi @metamas 👋

Thank you for creating the issue and for submitting the pull request.
The release 4.8.0 is now available.

Cheers!

  • 👍1