herotc/hero-rotation

Hero Rotation Buttons not showing up on shaman[Bug]:

Closed this issue · 5 comments

What version of HeroRotation are you using?

10.2.0.06

What version of HeroLib are you using?

10.2.0.01

What version of HeroDBC are you using?

10.2.0.02

What is the issue?

Randomly during combat in dungeons the buttons wont show up anymore and stop showing up for a longer amount randomly ( 5+ globals) happened after i updated the addon today on curseforge

Icon Behavior

Icon disappears

Elemental? Enhancement?

Link your talent build.

If the icon is disappearing, a lua error is occurring. Please enable lua errors with /console scriptErrors 1 and post the error here. You can later disable errors with /console scriptErrors 0.

Enhancement

BcQAzii1bx6MdXWQl8y/78bs6KRSKRCCJhcgk0QJRCAAAAAAAAAAAAoEhkQiWKiCJtkkCEKBBBC

happens mostly after i use elemental blast or have to use elemental blast ( it will not only not show elemental blast but also other abilities will not be shown)

Did you enable lua errors? What error do you receive when the icon disappears?

Message: Interface/AddOns/HeroRotation_Shaman/Enhancement.lua:146: attempt to index global 'Shaman' (a nil value)
Time: Sat Nov 11 21:57:18 2023
Count: 64
Stack: Interface/AddOns/HeroRotation_Shaman/Enhancement.lua:146: attempt to index global 'Shaman' (a nil value)
[string "=[C]"]: ?
[string "@Interface/AddOns/HeroRotation_Shaman/Enhancement.lua"]:146: in function <Interface/AddOns/HeroRotation_Shaman/Enhancement.lua:136>
[string "@Interface/AddOns/HeroRotation_Shaman/Enhancement.lua"]:683: in function `?'
[string "@Interface/AddOns/HeroRotation/Main.lua"]:456: in function <Interface/AddOns/HeroRotation/Main.lua:434>

Locals: (*temporary) = defined =[C]:-1


It´s a issue with Elemental Blast when i swapped away from it everything was fine

I have no idea why that didn't generate errors for me. It really should have. In any case, it's fixed in commit b22b184

You can either pull an updated Enhancement.lua file from the github or add a line after line 70.

Line 70: local Everyone = HR.Commons.Everyone
New Line: local Shaman = HR.Commons.Shaman

It'll also be included in future version 10.2.0.08.