herotc/hero-rotation

[Bug]: Issue with latest update arms warrior no longer supported

J603 opened this issue · 2 comments

J603 commented

What version of HeroRotation are you using?

10.2.6.18

What version of HeroLib are you using?

10.2.6.02

What version of HeroDBC are you using?

10.2.6.03

What is the issue?

Message: Interface/AddOns/HeroRotation_Warrior/Arms.lua:438: '' expected near ')'
Time: Sun May 5 19:27:53 2024
Count: 1
Stack: Interface/AddOns/HeroRotation_Warrior/Arms.lua:438: '' expected near ')'
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'

[string "@Interface/AddOns/HeroRotation/Main.lua"]:395: in function `PulseInit'
Message: Interface/AddOns/HeroRotation_Warrior/Arms.lua:1 Interface/AddOns/HeroRotation_Warrior/Arms.lua:438: '' expected near ')'
Time: Sun May 5 19:27:53 2024
Count: 2
[string "@Interface/AddOns/HeroRotation/Main.lua"]:303: in function <Interface/AddOns/HeroRotation/Main.lua:300>

Locals: (*temporary) = defined =[C]:-1

Icon Behavior

Icon does NOT disappear

if S.Whirlwind:IsReady() and (S.StormofSwords:IsAvailable() and not S.TestofMight:IsAvailable().) then

Looks like just an extra period in this conditional was added in yesterday's patch. This changed line fixed it for me.
if S.Whirlwind:IsReady() and (S.StormofSwords:IsAvailable() and not S.TestofMight:IsAvailable()) then

This has been fixed in commit eb543ff which will be included in release version 10.2.6.19.