hexlet-codebattle/battle_asserts

Fix or refactor disabled tasks

solar05 opened this issue · 3 comments

There are some disabled tasks, that needs to be fixed or refactored.
Disabled tasks list: all_symmetric_pairs, build_key_value, celsius_to_fahrenheit, counting_words, flatten, fridge_fun, parse_post_form_params, remove_duplicates, rotate_sequence, sea_battle, straight_line_equation, vasya_and_sword.

@solar05 Hey there, can you describe what is wrong on the mentioned tasks?
Which ones need refactoring and which ones need fixing?
I can take a look at them.

@michellymenezes hi, thanks for your interest!
Tasks fridge_fun and sea_battle needs solution and arguments-generator functions, you can check readme, for clarification about for what those function uses.
all_symmetric_pairs, build_key_value, celsius_to_fahrenheit, counting_words, flatten, parse_post_form_params, remove_duplicates, rotate_sequence, straight_line_equation and vasya_and_sword has issues with params, that they uses or solutions. One possible variant is changing the description of tasks (this can cause task difficulty changes) and fixing their input params, signatures, and generators for updated tasks condition. For example, in celsius_to_fahrenheit, floor rounding is used. Still, in Codebattle, users can solve tasks in many programming languages, and floor rounding can lead to incorrect results because of language-internal numbers representation. As my suggestion, the task description may be changed to the condition when float rounding is not needed, but for now, I have no idea how this task can be rephrased :( For other tasks, situations are the same. If you still have any questions, I am happy to help and answer them!

vtm9 commented

@michellymenezes you can also just create your own new tasks, and then play them on codebattle.hexlet.io