hhvm/homebrew-hhvm

Most recent homebrew jemalloc is too new

oyamauchi opened this issue · 6 comments

Description

After building hhvm with brew, every invocation results in this error message during startup:

<jemalloc>: Invalid conf pair: lg_dirty_mult:5

This is because that config option was removed in jemalloc 5.0.0 (source: https://github.com/jemalloc/jemalloc/blob/dev/ChangeLog#L161), which was added to homebrew-core on June 13, 2017 (source: Homebrew/homebrew-core@7c2104a).

I'd suggest adding jemalloc 4.5.0 to this tap and having the hhvm formula depend on that.

Context and Logs

Parameter Value
OS X Version: 10.12.5
Homebrew Version: 1.2.3-43-g8a5f1207
Xcode Version: 8.3.3

Output of clang -v:

Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

+1 the same

A pull request would be great.

Reopening as that was reverted in cc7140f

+1 happening again

I never saw the issue that led to my PR being reverted, FWIW.

Appears fixed with 3.21