image stretching
Closed this issue · 4 comments
display method fill was hard-coded, resulting in image stretching
A fix PR #3 has been submitted to remove the hard-coded 'fill' and provide settings for contain, cover, and fill
Thanks for the PR! If possible, could you please provide a screenshot or some other kind of example of the problem you faced that led you to create this PR?
The hard-coded fill and resulting image stretching was intentional. On smaller viewports, wider images like in CG sets can be hard to read and the fill property helped with that, but I can see why someone would want another option for viewing an archive's images. At the same time though, that option should be separate from the display method for the thumbnails. The cover option is also a pretty detrimental viewing experience for wider images in smaller viewports.
PR-contain like Webtoon reading mode in Tachiyomi
I believe it is important to maintain the aspect ratio of the image to ensure that it does not distort. So i add the contain display method
There is no objection to separating the display modes for thumbnail and archive. But perhaps those who can accept the archive display method can also accept the same display method for thumbnail.
screenshot
Just pushed up an update and added the setting. Should basically work the same as your PR. The Cover display method is still shot, but that can be fixed later.