hiddenSymmetries/simsopt

Strainopt tests

Closed this issue · 2 comments

@ejpaul

Could you please check the tests in test_strainopt.py? In particular, I am confused with the subtest_binormal_curvature and subtest_torsion. You are not asserting any conditions and the setting of errf_old variable is not clear.

ejpaul commented

Thanks, @mbkumar. I have created PR #373 to address this.

Fixed in #373