hiddevdploeg/Billboard

[BUG] Crashes app when app name contains spaces

Closed this issue · 2 comments

chronikum commented

Hello, during development I found this issue

image

It seems like, looking at the frame variables that appName seems to cause the the issue

image

because the url cannot be constructed, as there is a space in the app name.
Of course, this would be valid for any character that is not allowed in urls.

Several apps have this issue when looking at the default list:

https://billboard-source.vercel.app/ads.json

omit2c commented

It's also not necessary for the AppStore link to have the app name in it.
The link will also work like this: https://apps.apple.com/app/id\(appID)

hiddevdploeg commented

Should be fixed with #21