hieuwu/android-groceries-store

Bug - Can not add the same item to cart

Closed this issue · 2 comments

Thank you Devendra34 for pointing this out
Describe the bug
Can not add the same item to cart. We should be able to add the same item to cart

To Reproduce
Steps to reproduce the behavior:

  1. Launch the app and add some item from shop fragment using plus icon
  2. open cart bottom sheet. (added items are shown properly till here)
  3. now close this bottom sheet and add another item same as step 1
  4. open the cart bottom sheet again. Now you will not see the recently added item in the list

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
https://user-images.githubusercontent.com/51832211/193946013-965e3d7e-5c2a-48b6-88b2-f917232f622c.mp4

Additional context
Looks like this is due to the latest PR merged (#130 )

Hi @DeKaN , could you please take a look at this? It's ok if you don't have time, please let me know.

DeKaN commented

@hieuwu I replaced hot observable by cold observable at this line and it seems the cause of this bug