[flash-swap] Merge the "CollateralFlashUniswapV2" and "UnderlyingFlashUniswapV2" contracts

Question

[flash-swap] Merge the "CollateralFlashUniswapV2" and "UnderlyingFlashUniswapV2" contracts

PaulRBerg opened this issue 3 years ago · 2 comments

Thanks to 32dd173 and 7f042ab, the CollateralFlashUniswapV2 and UnderlyingFlashUniswapV2 have become very much alike.

By passing an additional variable to the flash swap ABI-encoded data, say "repayToken", we could potentially merge the contracts. That will remove a big chunk of technical debt.

Answer 1 · 2021-11-15T17:52:56.000Z

I started working on this in the refactor/flash-swap branch.

Answer 2 · 2021-12-20T19:25:13.000Z

Closing now.

I should have closed this issue on Nov 16, when I merged PR #69 into the main branch.