higherkindness/rules_scala

Scaladoc rule fails when including dependencies

kjbass opened this issue · 2 comments

When using the scaladoc rule and including a dep tag I get the following error. Stacktrace points to

classpath = depset(transitive = [dep[JavaInfo].transitive_compile_time_deps for dep in ctx.attr.deps])

Not sure if this is something to do with my environment, or a known problem with the scaladoc rule, but wanted to put this out here in case anyone else is running into a similar issue.

If more information is needed, or this is not the proper format you all prefer for issues to be created in please let me know, definitely don't want to be creating superfluous issues if I am just missing something obvious.

'JavaInfo' object has no attribute 'transitive_compile_time_deps'
Available attributes: annotation_processing, compilation_info, compile_jars, full_compile_jars, outputs, runtime_output_jars, source_jars, transitive_compile_time_jars, transitive_deps, transitive_exports, transitive_runtime_deps, transitive_runtime_jars, transitive_source_jars

Thanks for spotting this @kjbass

I went ahead and opened a PR with a fix and updated the scaladoc test s.t. it tests using deps. It seems we meant to use JavaInfo's transitive_deps attribute.

Once the fix is merged you should be good to go. Let us know if you run into any other issues :)

That sounds great, thanks for the super quick turnaround time! If I find anything else I'll be sure to let you all know.