him229/TwitteriOS

W[4]-Submission?

Opened this issue · 3 comments

minhchau273 commented

Hi Himank,

It looks like you have not created an issue for your submission. Please create an issue for all future project submissions following the steps in the submission guide.
It does not appear that you have added a README file to your Repo. Please add a README file, and use the README template to fill out the README. Be sure to also include an animated gif in your README to show a demo of your finished app. When properly linked, the gif should render (animate) within your README file.

Your assignment needs to be updated within 24hrs in order for you to receive credit for this assignment.

Best,
Chau

him229 commented

Now Complete. Please review. Messaged Charlie on Slack and e-mailed Chau. Apologies for the inconvenience.

minhchau273 commented

Assignment 4

👍 Nice work! The point of this homework was to explore an example of a full MVC application with a RESTful API.

Some small comments:

  • Nice work specifying the Auto Layout constraints.
  • Nice work setting up the controls within the Tweet cells. It can sometimes be hard to have a clean design for embedded controls because it usually involves cumbersome plumbing. This is an instance where I think having the model handle the network action helps greatly simplify the implementation.

Notice: Please update README for the assignment 4.

We have a detailed Project 4 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at universitysupport@codepath.com.

minhchau273 commented

Assignment 5

👍 Nice work! We added this homework so that you'll have the experience building an app that's more similar in complexity to a production app. The optional account switching feature is interesting because you have to think about how TwitterClient is caching the access token to make sure it works correctly for multiple accounts.

Some small comments:

  • You should try using delegate to implement the post tweet insertion into the feed. In real MVC apps, the more polished experiences have to do a certain amount of local object management to make a fully seamless experience.
  • In ComposeViewController, the Submit button is overlapped by the keyboard, so I cannot tap it. Remember that you cannot hide the keyboard in real devices.

We have a detailed Project 5 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at universitysupport@codepath.com.