`String` -> `Arc<str>`
Closed this issue · 0 comments
hinto-janai commented
What
The Collection
has many cloned String
's, and slightly different versions of those String
's are often created, like in Search
where .to_lowercase_ascii()
is applied each search.
This is inefficient.
Todo
- All
String
's, notablyArtist::name
,Album::title
,Song::title
should beArc<str>
so they can be cheaply cloned - Lowercase (maybe uppercase too) versions should be pre-calculated and stored in the
Collection