Rejection handling doesn't seem to be working

Question

Rejection handling doesn't seem to be working

Closed this issue 8 years ago · 5 comments

Hi,

I have a component that makes a GET request to an API endpoint. When this API call results in a non-success status code (i.e. 400), I would have expected the fetch state to be rejected.

Right now, this is not the case. When this situation occurs, the state is set to fulfilled.

I suspect it has something to do with the following line:

https://github.com/hirviid/react-redux-fetch/blob/master/src/utils/handleResponse.js#L4

Since an error response has no content-length, it ends up in this if-branch, but that doesn't actually reject the promise.

Answer 1 · 2017-02-28T15:41:11.000Z

Hm yeah indeed. This was a literal copy-paste from react-refetch. But I guess we can do a Promise.reject... if the status is not in the 200 - 300 range.

I don't think this will cause problems for anyone. As you say, a 400 should be rejected.

Answer 2 · 2017-03-01T07:38:01.000Z

Yes, that sounds reasonable 👍

Answer 3 · 2017-03-03T06:41:40.000Z

Any idea when you'll publish the new version? :)

Answer 4 · 2017-03-03T07:46:35.000Z

Now! :)
Available in react-redux-fetch@0.8.0

Answer 5 · 2017-03-03T08:03:04.000Z

Haha awesome, thanks! :)