hitblast/avro.py

Move to poetry and masonry for deployment?

baseplate-admin opened this issue · 10 comments

baseplate-admin commented

Hi,

It seems you are using setuptools to install the application. But the entire python ecosystem is moving towards pyproject.toml format.

Check this reddit thread for why people chose poetry over setuptools.

Thanks in advance

hitblast commented

@baseplate-admin Thanks for this update! I really appreciate it and will look into it as soon as possible.

  • 👍1
hitblast commented

main...migrate-poetry

@baseplate-admin Hey, I've made the basic changes for migrating the project to Poetry. I'd also like to talk about if we should keep the setup.py file for legacy purposes or not. Feel free to check when you're free. Thanks!

baseplate-admin commented

Could you please open a pull request? i will do verification there.

Karon eibhabe verification korte gele onek onek pera hobe :)

  • 👍1
hitblast commented

@baseplate-admin accha thikache :)

  • 🚀1
baseplate-admin commented

image

You should always commit lock file to allow dependabot to update deps

hitblast commented

tumi chaile https://github.com/baseplate-admin/django-ltree-2/blob/55584e9075cad1c9f4a0141523048630a52a4121/.github/workflows/publish.yml ei type kisu use krte paro, publishing onek easy hobe taile

Yeah ekta workflow file pore add kore dicchi dw

hitblast commented

@baseplate-admin okay read all of your comments, attempting to adjust it

  • 👍1