Project could benefit from some more DI examples around UI
ZacSweers opened this issue · 5 comments
Should probably have some more fleshed out dependency injection examples if you want it to be a resource on good DI practices
@hzsweers The inject annotation is used within the DataManager class for the dependancies within it, not sure if you saw the use there? But it's not used much elsewhere, I can always expand on the use of injection if you feel it needs to be
Ah must have missed that. I did a search on the repository itself for
"@Inject" but it turned up zero results, should've gone and done a manual
check as well. I think it would benefit from more examples, particularly in
areas dealing with UI.
On Thu, Aug 27, 2015, 2:03 AM Joe Birch notifications@github.com wrote:
The inject annotation is used within the DataManager
https://github.com/hitherejoe/Android-Boilerplate/blob/master/app/src/main/java/com/hitherejoe/androidboilerplate/data/DataManager.java
class for the dependancies within it, not sure if you saw the use there?
But it's not used much elsewhere, I can always expand on the use of inject
if you feel it needs to be—
Reply to this email directly or view it on GitHub
#7 (comment)
.
@hzsweers github search has let me down many a times, no worries! I agree with that though in regards to UI cases, i'll add some uses in soon when I get a chance 👍
Sounds good!
On Thu, Aug 27, 2015, 2:18 AM Joe Birch notifications@github.com wrote:
@hzsweers https://github.com/hzsweers github search has let me down
many a times, no worries! I agree with that though in regards to UI cases,
i'll add some uses in soon when I get a chance [image: 👍]—
Reply to this email directly or view it on GitHub
#7 (comment)
.
Oh my god Joe I didn't know we've been friends this long 👀