hive-keychain/hive-keychain-extension

transfer Tokens check Balance

AleksandrAsimov opened this issue · 2 comments

AleksandrAsimov commented

When I use transfer Tokens
unknown
and my balance does not enough to send token, transaction callback info success is true and write into blockchain.

4Ykw commented

I am not 100% sure if the callback checks for these kinds of conditions.

But yeah.. although the write into blockchain will not get processed. UI enhancement? 😉

stoodkev commented

Somehow missed that issue.
Yea there's definitely a UI enhancement to be made here.
And as you say, there's no error since it's nothing but a JSON broadcast that is successful. I'll make sure the confirm button is greyed out if the amount is bigger than balance.
This is an edge case though, as this is usually already handled by the dApp before sending the request.

I'll probably fix this after the current refactor is done since it's not urgent.

  • 👍2