hjacobs/kube-janitor

At least some version tags in this repo are placed on the wrong commits

sryabkov opened this issue · 2 comments

sryabkov commented

The 20.2.0 tag is placed on commit f395fbc instead of 86e1dea, which follows it.

When one does git checkout 20.2.0, they get 20.2.0 bits with the 20.1.0 version number

Please see the screenshot

image

It looks like this is an issues that persists throughout versions:

image

I can see three possible remedies:

  • re-do the tags and releases and start making tags/releases on the right commits in future
  • leave everything as-is and make a note of this issue in README
  • leave this issue open so that consumers can see it in the list of open issues

Others have been confused by this, as can be see in this comment

hjacobs commented

It's actually more or less on purpose, as I first tag/release and afterwards increment versions in the deployment manifests and README. I don't consider this an issue --- e.g. I might release something, test it on some server, and afterwards bump the versions in README/manifests.

sryabkov commented

@hjacobs I figured you didn't consider this to be an issue, otherwise you wouldn't be doing it, but I suspect most (or at least some) people would be tripped by this, that's why I created the issue.