hkirat/notification-logger

No npm package?

Closed this issue · 10 comments

No npm package?

@sleewoo If the author @hkirat does not want to create npm package, I will fork the project and create it.

In addition, I can extend the project to also supply an icon property (see related issue #1)

I have creating the npm package. Updating it soon @mikeerickson

@hkirat cool, thanks!

@hkirat will you be adding the icon property as well?

I'll be modifying the website and Readme for now. I'll take that up later. You can file for a P.R. if you wish.

@hkirat I will issue PR after you have completed the npm package.

@hkirat OK, sounds good. I will add the icon property later today and get a PR submitted by EOD. Thank you for your efforts.

@sleewoo @hkirat Just to be clear and properly set expectations.

The creation of the npm package is only for the requirement to install package via npm as opposed to downloading the archive. The method of use remains the same as if you were to download.

TL;DR the npm package install does NOT provide a commonJS format (or UMD) which would allow it to be installed into your application using ES5 require or ES6 import