Flag freeze is wrong
Closed this issue · 4 comments
The flag is being used inversely to the real.
Look at the snippets:
https://github.com/hkzorman/advanced_npc/blob/master/npc.lua#L481
https://github.com/tenplus1/mobs_redo/blob/master/api.lua#L2581
Yes, this can be changed. However it will require changes in many places and have to be done carefully.
What would you prefer, to change the variable name?
I will leave this open until I get to work on this.
If this really is completely reversed, you just have to reverse its meaning, however if you really believed what is described in the code, then it is possible that there are errors in your code, and you will need to revise it.
I'm 100% conscious that the flag is reverse used, so in terms of logic I'm fairly sure there are no issues.
I think I will rename it to self.unfreeze, that way will be consistent with the assignments.
Makes sense?
Yes, it is ok!