hlxsites/vg-roadchoice-com

CR: search has also a description search, not only by part number

Closed this issue · 4 comments

jonatan-lledo-netcentric commented

Commented by Jane:
"update the search to be Part Number or Description. Having both listed on the actual search bar would be great too. Thank you!!"

So, both searches will search by description as follows:

  • CR -> Description column
  • PN -> Part Name column

UPDATE

The updated acceptance criteria is that the PN search is the only search type that has to have the description search, not the Cross-Reference

girishdigrajkar commented

Bugs identified:

  1. Bug: Content : 8571 rows of data does not have Make/ Model data [GD 25 OCT 23] Model "Others" covers it so no issue

  2. The search works with contains filter [GD 25 OCT 23] Able to get the correct results
    It contradicts with the data used by business:
    Case1: User searches for Volvo make VNR model however gets results of all VNR, VNR 300, VNR400
    Case2: User searches for Freightliner & Century make however, gets data for Century only & 'Century, Columbia' which is correct with 'contains' used in code. however, if code uses strict equalto value then case2 will not include results of 'Century, Columbia' data (edited)
    image

  3. Category filter showing more results than expected : [GD 25 OCT 23] Able to get the correct results now
    image

  4. Show more is not displayed although search results are total 14 in number i.e. 2 more than pagination of 12 /page:
    image [GD 25 OCT 23] Able to get the correct results

Gonzalo-CG commented

Previously estimated at 3sp, after testing the complexity was changed to 5sp.

girishdigrajkar commented

Validated and above issues are no more observed so updated comments in line.

Below are outstanding observations which need to be investigated :
1. This page shows 6results and then refreshes automatically and then shows 3 results this flicker is not expected : https://www.roadchoice.com/search/?q=&st=parts&make=autocar&model=null&cat=shock+absorbers

2. When clicked on category link the records shown are more than expected :
https://www.roadchoice.com/search/?q=&st=parts&make=ford&model=null

Click on Radiators link and validate the count
image

3. Navigate to https://www.roadchoice.com/search/?q=&st=parts&make=freightliner&model=null
image

Click on any category it shows incorrect count
image

now click browser back button and it shows all incorrect counts :
image

girishdigrajkar commented

Validated and able to get the correct results and hence, marking this ticket to done status. OEM_num details were searched and correct result was displayed.