Rename isRunning to isStarted in Bench.php

Question

1e1 opened this issue 9 years ago · 5 comments

Renamming property and method isRunning to isStarted should be more explicit.
For a while isRunning() should be depricated.

Answer 1 · 2015-08-06T10:46:57.000Z

This is more question like an issue, because it will break the BC and we would like to avoid that.

Answer 2 · 2015-08-06T10:47:21.000Z

I assigned @vonglasow to lead the reflection.

Answer 3 · 2016-03-22T13:02:11.000Z

@1e1 so why you want to rename this api? What is the betterment to rename the method?

Answer 4 · 2017-02-17T17:41:23.000Z

@1e1 do we continue the discussion or can we close this issue ?

Answer 5 · 2017-03-06T10:51:40.000Z

After discussion, we have agreed to rename this method. @1e1 can you handle it and create a PR?