Conflict with PHP7

Question

Conflict with PHP7

Hywan opened this issue 10 years ago · 9 comments

Hello 😄,

PHP7 has a new keyword: string. To bad for us, it makes Hoa\String crashes because we can no longer use this keyword.

Here, we need to rename this library. I suggest Hoa\Ustring, like ustring (“unicode strings”). This would be pretty logical.

How to migrate then, without breaking code? It will break the code, for sure, but it will create a new library. Here is my proposal, probably not perfect, feel free to comment:

create Hoa\Ustring,
import Hoa\String into Hoa\Ustring and update the code, documentation, tests and README.md,
rename the Git repository on git.hoa-project.net, github.com/hoaproject and pikacode.com/hoaproject from String.git to Ustring.git (this way we don't lost stargazers & co.),
update Packagist to point to github.com/hoaproject/Ustring,
update composer.json library's name to hoa/ustring (here, we will break stuff and lost Packagist numbers),
update all dependencies on Hoa,
update the website,
create Hoa\String, extending Hoa\Ustring but deprecated,
update Hoa\Core\Consistency::isKeyword (with other libraries, like Hoa\Realdom).

We could keep the String.git repository for some time, I don't know. As far as I know, nobody requires hoa/string directly, but only through others libraries.

Thoughts @hoaproject/hoackers?

Jir4 commented 10 years ago

👍

Answer 1 · 2015-05-13T08:48:09.000Z

To be frank, I thought https://wiki.php.net/rfc/context_sensitive_lexer would resolve the issue, but it lands in PHP7 and nothing is solved 😁.

Answer 2 · 2015-05-13T08:53:50.000Z

I suggest to create Hoa\String and extend Hoa\Ustring to not break code for php < 7

Answer 3 · 2015-05-13T08:59:55.000Z

See new reserved keywords: http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_compile.c#reserved_class_names (thanks @weltling for the link).

Answer 4 · 2015-05-13T09:01:18.000Z

@marmotz Good idea! With a separate library, so. We could move Hoa\String to Hoa\Ustring and then create a new Hoa\String library that extends Hoa\Ustring, and require php: '< 7'. It could work.

Answer 5 · 2015-05-13T09:14:33.000Z

11:12 @weltling Hywan, i haven't test the context sensitive lexer branch ... you could do a quick try and see if it's doing something, as that RFC targets 7.0 one
11:12 @weltling if it doesn't fix, probably won't fix at least in 7.0

… compiling :-).

Answer 6 · 2015-05-13T22:42:49.000Z

Funny, during Phptour talk, a guy from SensioLabs talk about same problem for Symfony.
my thought going also for Ustring 👍

Answer 7 · 2015-05-29T08:07:20.000Z

todo list updated.

Answer 8 · 2015-05-29T08:55:34.000Z

Related to hoaproject/Core#80.