Make iconv requirement optional
webmozart opened this issue · 7 comments
I'm currently looking at integrating hoa/console into the webmozart/console library. However, hoa/console depends on hoa/ustring, which in turns requires the iconv extension to be installed.
Does this really have to be a hard requirement instead of a suggest? As far as I saw, iconv is only needed for Ustring::transcode(). You could check whether the function is available there, throw an exception otherwise and add iconv to "suggest" instead. I'd be happy about reduced dependencies.
Hello :-),
Good news!
Yes it is possible. I will fix it as soon as possible. The same way ext/mbstring is suggested, ext/iconv must be suggested too, you're right.
Great, thanks! :)
👍
I won't be able to do that today, maybe this weekend or Monday for sure.
@webmozart Normally, we have to wait 6 weeks before the next snapshot (“release”/tag). We don't create a new snapshot because it's not a bug fix (please see http://hoa-project.net/Source.html#Rush_Release). However, we can do an exception, it's not a hard rule (since we have rolling release, we don't really care about tags 😉). The question is: Do you need a new snapshot now or can you wait approximately 6 weeks?
@webmozart Finally I created a new snapshot since we can consider the ext/mbstring global check as a bug fix. So here is the https://github.com/hoaproject/Ustring/releases/tag/3.15.08.03 😄. Happy coding!
Wow, that's some service! Thanks :)