BigEndian vs LittleEndian
MinusPL opened this issue · 1 comments
MinusPL commented
Each packet in PacketType has wrong hex value.
Every packet is sent in Little Endian bytes. That means that most significant byte is actually on the right, not left.
Due to this every packet has wrong numerical value assigned. For example:
Packet ClientEnterServerReq is actually assigned to value 0x1302 rather than 0x0213. 0x0213 is shown in any raw binary dump of data.
Didn't notice if you meant to have them in Little Endian byte order, but it can cause some problems.
holly-hacker commented
Seems like it's an update to the protocol then, this worked fine in the past. I'm not really interested in maintaining this so feel free to make a fork.