holodeck-b2b/Holodeck-B2B

InFlow: the message will be delivered even if its state is FAILURE ?

tigran-a opened this issue · 1 comments

tigran-a commented

Hi,

Probably I'm missing something...
PerformCustomValidations handler does not care about the current message unit state other than DUPLICATE (where the handler does nothing).
If the message was in the FAILURE state (e.g. after ProcessSecurityHeaders decided so), the mentioned handler will change its state to READY_FOR_DELIVERY:

Holodeck-B2B/modules/holodeckb2b-core/src/main/java/org/holodeckb2b/core/handlers/inflow/PerformCustomValidations.java

Line 69 in f892b53

HolodeckB2BCore.getStorageManager().setProcessingState(userMessage,

and DeliverUserMessage will deliver it to the business application.

Thanks in advance for a clarification

sfieten commented

Because the PerformCustomValidations extends org.holodeckb2b.common.handlers.AbstractUserMessageHandler it already excludes processing of _User Message_s in FAILURE state. However it indeed would be better to check on whether the current state is still PROCESSING before validating the message and possibly setting its state to READY_FOR_DELIVERY.
This change has now been applied in version 6.0.1