holoviz/lumen

Hanging loading spinner on a custom view that doesn't implement `_get_params`

maximlt opened this issue · 2 comments

To implement a custom view one should implement the get_panel method that returns a Panel object. In order to avoid rebuilding the whole Panel object/view on every update/render one can implement the private method _get_params that should return a dictionary of Parameter values that are used to update the Panel object when need be (with something like panel_obj.param.set_param(**params)). When _get_params isn't implemented, the custom view inherits from the base _get_params method that simply returns None to signal that this way of updating an existing Panel object isn't available.

When _get_params isn't implemented a filter change effectively triggers a full update of the view, but also adds a loading spinner (via Dashboard._set_loading) on the view that is never deactivated and so prevents any further action on the view.

If _get_params is meant to be used by users who implement a custom view, it should be made public and documented.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.