home-assistant/core

Rename photovoltaic entities to "PV" to differentiate from thermal Solar

NoRi2909 opened this issue · 3 comments

NoRi2909 commented

The problem

In the Vicare integration there are seven entities which relate to PV installations, obvious from their entity IDs:

core/homeassistant/components/vicare/strings.json

Lines 349 to 372 in 1f9c06e

"photovoltaic_power_production_current": {
"name": "Solar power"
},
"photovoltaic_energy_production_today": {
"name": "Solar energy production today"
},
"photovoltaic_energy_production_this_week": {
"name": "Solar energy production this week"
},
"photovoltaic_energy_production_this_month": {
"name": "Solar energy production this month"
},
"photovoltaic_energy_production_this_year": {
"name": "Solar energy production this year"
},
"photovoltaic_energy_production_total": {
"name": "Solar energy production total"
},
"photovoltaic_status": {
"name": "Solar state",
"state": {
"ready": "Standby",
"production": "Producing"
}

These should have their entity names changed from "Solar …" to "PV …" to differentiate them from this group:

core/homeassistant/components/vicare/strings.json

Lines 293 to 303 in 1f9c06e

"solar_power_production_today": {
"name": "Solar energy production today"
},
"solar_power_production_this_week": {
"name": "Solar energy production this week"
},
"solar_power_production_this_month": {
"name": "Solar energy production this month"
},
"solar_power_production_this_year": {
"name": "Solar energy production this year"

Here the use of "power" in the entity IDs is wrong and should be replaced with "energy".

Alongside the name of this entity

core/homeassistant/components/vicare/strings.json

Lines 33 to 35 in c294130

"circulation_pump": {
"name": "Circulation pump"
},

should be changed to "Heating circulation pump" to make it consistent with this one:

core/homeassistant/components/vicare/strings.json

Lines 51 to 53 in c294130

"domestic_hot_water_circulation_pump": {
"name": "DHW circulation pump"
},

Avoids major misunderstandings as in Germany the circulation pump is only known for DHW.

What version of Home Assistant Core has the issue?

2024.10.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Viessmann ViCare

Link to integration documentation on our website

https://www.home-assistant.io/integrations/vicare/

home-assistant commented

Hey there @CFenner, mind taking a look at this issue as it has been labeled with an integration (vicare) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vicare can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign vicare Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

vicare documentation
vicare source
(message by IssueLinks)