home-assistant/core

Groups: Broken grammar in several issues strings, room for improving the details

NoRi2909 opened this issue · 1 comments

The problem

Repair messages for group sensors contain several grammar bugs. Here just two I was able to trigger easily:

Screenshot 2024-10-23 22 16 55

First of all the correct term to use is found here:

"unit_of_measurement": "Unit of Measurement"

Below almost all strings have broken grammar in English and are in need of a makeover:

"issues": {
"uoms_not_matching_device_class": {
"title": "Unit of measurements are not correct",
"description": "Unit of measurements `{uoms}` of input sensors `{source_entities}` are not compatible and can't be converted with the device class `{device_class}` of sensor group `{entity_id}`.\n\nPlease correct the unit of measurements on the source entities and reload the group sensor to fix this issue."
},
"uoms_not_matching_no_device_class": {
"title": "Unit of measurements is not correct",
"description": "Unit of measurements `{uoms}` of input sensors `{source_entities}` are not compatible when not using a device class on sensor group `{entity_id}`.\n\nPlease correct the unit of measurements on the source entities or set a proper device class on the sensor group and reload the group sensor to fix this issue."
},
"device_classes_not_matching": {
"title": "Device classes is not correct",
"description": "Device classes `{device_classes}` on source entities `{source_entities}` needs to be same for sensor group `{entity_id}`.\n\nPlease correct the device classes on the source entities and reload the group sensor to fix this issue."
},
"state_classes_not_matching": {
"title": "State classes is not correct",
"description": "State classes `{state_classes}` on source entities `{source_entities}` needs to be same for sensor group `{entity_id}`.\n\nPlease correct the state classes on the source entities and reload the group sensor to fix this issue."
}
}
}

Should be

  Units of measurement are not correct
  Unit of measurement is not correct
  Device classes are not correct
  State classes are not correct

In the explanations correct all occurrences of "unit of measurements" to "units of measurement" or "unit of measurement" (depending on the "are" or "is" that follows).

And have a good look over the rest of the wording, I think there is room for improvement, too.

What version of Home Assistant Core has the issue?

2024.10.3