home-assistant/core

HVV integration shows delay in seconds, not in minutes

N1c093 opened this issue · 5 comments

N1c093 commented

The problem

Currently the hvv integration shows the delay of a bus or train in seconds and not in minutes. I normally would think that the delay is represent as minutes, because on the hvv website the delay is also represented in minutes.

See example:

Home Assistant:
image

HVV webpage:
image

Actually I don't know if this is a real issue or "worked as design". Anyway I think it would be better, if the behavouir is the same as on their webpage.

What version of Home Assistant Core has the issue?

core-2022.10.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

hvv_departures

Link to integration documentation on our website

https://www.home-assistant.io/integrations/hvv_departures/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant commented

Hey there @vigonotion, mind taking a look at this issue as it has been labeled with an integration (hvv_departures) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hvv_departures can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant unassign hvv_departures Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)

hvv_departures documentation
hvv_departures source
(message by IssueLinks)

vigonotion commented

We get the delay in seconds from the hvv api. The hvv website just converts it into minutes.
You can do that in your dashboard as well, I wouldn't change it to seconds just for visuals.

But, did you find it confusing? Maybe then we should add attribute descriptions to the documentation page so people know the delay is in seconds?

N1c093 commented

Technically you are absolutely right.
But I don't see any reason to have the delay in seconds. I think the delay from the api will always be an multiplier of 60 seconds.

For me it's okay to leave the delay in seconds. Your suggestion to update the documentation sounds great.
Will you update the documentation or should I create a Pull Request?

vigonotion commented

I will do that tomorrow

N1c093 commented

Thank you for your explanation and for updating the documentation.
In general thank you for the hvv integration.

I will close this issue. Have a nice weekend.