home-assistant/supervised-installer

missing package dependency: systemd-resolved

dothebart opened this issue ยท 13 comments

Describe the issue you are experiencing

the debian package invokes systemctl enable systemd-resolved.service however, it needs to pre-depend on it to warrant its available.

It also seems, as bluetooth support only comes alive once bluez is installed on the host, could also be considered a dependency then.

What type of installation are you running?

Home Assistant Supervised

Which operating system are you running on?

Debian

Steps to reproduce the issue

dpkg --pending --configure 
Setting up homeassistant-supervised (1.7.0) ...
+ BINARY_DOCKER=/usr/bin/docker
+ DOCKER_REPO=ghcr.io/home-assistant
+ SERVICE_DOCKER=docker.service
+ SERVICE_NM=NetworkManager.service
+ URL_CHECK_ONLINE=checkonline.home-assistant.io
+ URL_VERSION=https://version.home-assistant.io/stable.json
++ curl -s https://version.home-assistant.io/stable.json
++ jq -e -r .supervisor
+ HASSIO_VERSION=2024.03.1
+ URL_APPARMOR_PROFILE=https://version.home-assistant.io/apparmor.txt
+ info 'Reload systemd'
+ echo -e '\e[32m[info] Reload systemd\e[39m'
[info] Reload systemd
+ systemctl daemon-reload
+ info 'Restarting NetworkManager'
+ echo -e '\e[32m[info] Restarting NetworkManager\e[39m'
[info] Restarting NetworkManager
+ systemctl restart NetworkManager.service
++ stat -c %a /etc/systemd/resolved.conf
+ '[' 644 '!=' 644 ']'
+ info 'Enable systemd-resolved'
+ echo -e '\e[32m[info] Enable systemd-resolved\e[39m'
[info] Enable systemd-resolved
+ systemctl enable systemd-resolved.service
dpkg: error processing package homeassistant-supervised (--configure):
 installed homeassistant-supervised package post-installation script subprocess returned error exit status 1
Errors were encountered while processing:
 homeassistant-supervised

Anything in the Supervisor logs that might be useful for us?

xx

System Health information

xx

Supervisor diagnostics

xx

Additional information

please add the dependency.

Moved to the Supervisor installer repositiory, as the deb is maintained in this repository.

FWIW, the dependency is listed in the installation instructions of the readme. I guess it (/all of them) could also be added to the deb, but maybe there are reasons this isn't being done? ๐Ÿค”

@ikifar2012, you probably know better ๐Ÿ˜…

It already has quiet a bunch. bluez should be considered as well. systemd-resolved is a pre-dependency pre-depends , it needs to be readily set up in order for the scripts to work.

Thanks for bringing this to my attention, I will definitely add bluez I completely forgot about it, I don't use Bluetooth so I guess I mistakenly forgot about adding the package

I am trying to figure out what packages should be part of the pre-depends, it seems a lot of them should be except for nfs-common, cifs-utils and bluez which I would list as regular dependency's. What are your thoughts on this?

Hm, I think only resolved got in my way because this was completely missing, and I downloaded the other ones beforehand.
But if the script invokes binaries installed from them, it should be in the pre-depends.

@ikifar2012 I've just re-installed the homeassistant-supervised package (on Ubuntu 22.04) and as part of the install it included this

The following NEW packages will be installed
  cifs-utils

However the next time I ran apt upgrade it tried to uninstall it...

The following package was automatically installed and is no longer required:
  cifs-utils
Use 'apt autoremove' to remove it.

So I assume there's an issue with how it's specified as a dependancy? Unsurprisingly without it the network storage using CIFS doesn't work. For now I've just run
sudo apt install cifs-utils
So it's now marked as manually installed so hopefully won't get removed.

You can check which packages depend on it like this:

apt-cache rdepends cifs-utils
cifs-utils
Reverse Depends:
  smb4k
  homeassistant-supervised
  smbclient
  udevil
  clonezilla
  smbclient
  libpam-mount
  kwartz-client
  freeipa-client-samba
  education-networked-common
  education-common

probably that dependency went missing?

Yes, looks like the homeassistant-supervised didn't stick. I ran sudo apt install ./homeassistant-supervised.deb then almost immediately sudo apt upgrade so I'm not sure why.

apt-cache rdepends cifs-utils
cifs-utils
Reverse Depends:
  smb4k
  smbclient
  smbclient
  casper
  smbclient
  libpam-mount
  casper
  udevil
  clonezilla
  kwartz-client
  freeipa-client-samba

@ikifar2012 I've just re-installed the homeassistant-supervised package (on Ubuntu 22.04) and as part of the install it included this

The following NEW packages will be installed
  cifs-utils

However the next time I ran apt upgrade it tried to uninstall it...

The following package was automatically installed and is no longer required:
  cifs-utils
Use 'apt autoremove' to remove it.

So I assume there's an issue with how it's specified as a dependancy? Unsurprisingly without it the network storage using CIFS doesn't work. For now I've just run sudo apt install cifs-utils So it's now marked as manually installed so hopefully won't get removed.

Not sure why this happened... that being said Ubuntu is not officially supported

Take a look at the latest release, I added BlueZ and moved some Dependency's to Pre-Depends