honestbank/kp

should producer really inject trace headers?

Closed this issue · 2 comments

If so, then what kind of trace is it supporting? KP's API has an option to not use this middleware but rather come up with our own. But the producer doesn't support middleware so is it really correct to inject headers as we see fit?

I'm inclined towards a no.

Maybe producer also should support a bit of middleware, that way people can add tracing only if they wanted to.

wrong PR got linked, opening again, will close the correct one.

it works for now and won't cause any issues. will tackle this again later if somoene has a need for custom tracing in the future. Just comment on this issue if you need this tackled.