hooklift/node-libvirt

Migrate and test with nodejs 0.6

c4milo opened this issue · 4 comments

Migrate and test with nodejs 0.6

Hi

Have you had any time to work on this yet?

I've got it to compile against the latest node. The only compilation problem was within domain.cc to do with the memcpy of buffers. I can provide a patch for this.

yeah sure, patches are welcome!. nodejs 0.4.x had a big change in Buffers, the only class where I am using them is domain.cc so far.

Sorry for the late response I was on vacations.

#4 builds, still needs more testing.

0.6.x is a different beast though, deeper changes.

This was closed by @tralamazza