Laravel 5.5 support
rluders opened this issue · 8 comments
Hello.
Is there any hope for the Laravel 5.5 compliant package?
@rluders I just tested it in L5.5 and it works fine. I did fork it (and change testing to use sqlite instead of mysql) here, if you're interested. Everything passes:
@nateritter good job! Could you submit a pr with the L5.5 tests?
@hootlex actually, the tests work fine as-is with L5.5. I just changed composer requirements. I made some other changes, like using sqlite instead of mysql. Reduces a dependency on Travis, and tests are slightly faster. If you want all that, I can just submit the PR with what I've got now?
@nateritter great. Do not forget about the package autodiscovery.
@rluders Yup, all part of it.
PR added: #92
Hey @nateritter, thanks for clarifying that it works fine as-is with 5.5. Since #92 is failing I'd rather stick with the current testing set up. Feel free to open a new pr if you think you can make the tests run faster. 🙂
Hmm. I didn't see it fail, where do I get to see that? I only switched it because I couldn't get it to work under the current test conditions and sqlite is a simpler setup. So, if that doesn't work, I'm happy to revise. But yea, it does all work as-is, so I guess there's no need to change anything if you don't want to.
As a side note, it would actually be better for testing purposes not to touch the database at all. I'm not a big "never touch the db" fan, but in this case, we're not dealing with acceptance tests. Unit tests don't need to touch the db, so the setup for contributors would be much easier (not requiring a separate CI, etc).
Just a thought for you to consider.