is the explicit removeChild in managed-append-child necessary?
Closed this issue · 2 comments
thedavidmeister commented
while writing tests for #205 i noticed that ??appendChild--internal-remove
does NOT fail when the following code is removed from managed-append-child
:
(when (.-parentNode child)
(.removeChild (.-parentNode child) child))
so either it is protecting against something the test doesn't consider or it is cruft.
removing it was out of scope for #205 so i put a followup ticket here for further investigation.
burn2delete commented
https://developer.mozilla.org/en-US/docs/Web/API/Node/appendChild
Not needed as per docs, can be removed safely.
burn2delete commented
removed in 7.2
branch.