hossein-zare/react-native-dropdown-picker

Not scrolling on android

stereodenis opened this issue ยท 8 comments

Hi! ๐Ÿ‘‹

Firstly, thanks for your work on this project! ๐Ÿ™‚

Today I used patch-package to patch react-native-dropdown-picker@5.4.6 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-dropdown-picker/src/components/Picker.js b/node_modules/react-native-dropdown-picker/src/components/Picker.js
index e3fb93b..12eb5ed 100644
--- a/node_modules/react-native-dropdown-picker/src/components/Picker.js
+++ b/node_modules/react-native-dropdown-picker/src/components/Picker.js
@@ -14,16 +14,15 @@ import {
     TouchableOpacity,
     Text,
     Image,
-    FlatList,
     TextInput,
     Dimensions,
-    ScrollView,
     Modal,
     ActivityIndicator,
     BackHandler,
     Platform,
     StyleSheet,
 } from 'react-native';
+import { FlatList, ScrollView } from 'react-native-gesture-handler';
 
 const { height: WINDOW_HEIGHT } = Dimensions.get('window');
 

This issue body was partially generated by patch-package.

I made the changes but it threw this error
Screenshot 2024-01-30 at 12 15 32โ€ฏPM

Thx @stereodenis , I just had the same issue ๐Ÿ‘

@YASH6004 You probably need to install it https://github.com/software-mansion/react-native-gesture-handler

@hossein-zare I have found an issue with Android too. I noticed the component has been updated here but in the node_modules the Picker.js file does not have the imports coming from react-native-gesture-handler.

Any idea why the version that is installed into the node modules is different?

Hi! ๐Ÿ‘‹

Firstly, thanks for your work on this project! ๐Ÿ™‚

Today I used patch-package to patch react-native-dropdown-picker@5.4.6 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-dropdown-picker/src/components/Picker.js b/node_modules/react-native-dropdown-picker/src/components/Picker.js
index e3fb93b..12eb5ed 100644
--- a/node_modules/react-native-dropdown-picker/src/components/Picker.js
+++ b/node_modules/react-native-dropdown-picker/src/components/Picker.js
@@ -14,16 +14,15 @@ import {
     TouchableOpacity,
     Text,
     Image,
-    FlatList,
     TextInput,
     Dimensions,
-    ScrollView,
     Modal,
     ActivityIndicator,
     BackHandler,
     Platform,
     StyleSheet,
 } from 'react-native';
+import { FlatList, ScrollView } from 'react-native-gesture-handler';
 
 const { height: WINDOW_HEIGHT } = Dimensions.get('window');
 

This issue body was partially generated by patch-package.
applied the same solution but scroll still not working in android.