Add CDF for Gaussian Distribution
hot9cups opened this issue · 9 comments
Here is the Gaussian distribution class.
It contains the PDF function but currently does not have a CDF function.
I would like it contain the CDF too.
I would also like appropriate unittests to be included in the test.py file
Hi, can I work on this?
Sure thing @RimorRes !
There's just one thing though, I'll need you to start working on this from day after tomorrow, because there are certain issues that I need to sort in the codebase, which I'll be doing tomorrow. Thanks :)
Ok, so I should start working on this on the 31st of October?
Can I start now and make the pull request on Saturday?
@RimorRes sure. You can do that, although be sure when you make the PR, you actually refresh the fork to have the latest version of the repo :)
Sure thing!
I finished implementing the CDF for the Gaussian distribution and am currently waiting for your go-ahead.
I'm hoping this PR will count towards my Hacktoberfest objective so I'd like to submit as soon as possible if it's fine by you.
@RimorRes ah, I see.
Right, I understand. In that case, you can open a PR now, and if everything works fine I'll add the hacktoberfest-accepted label immediately. Then I'll get to actually merging it later; that way your PR counts for hacktoberfest while I also get to wait before merging it