Add support for Poisson distribution
hot9cups opened this issue · 12 comments
Go through the Gaussian distribution class, the Binomial class and the Exponential class which are subclasses of General distribution class.
I would like to expand this to include another distribution, the Poisson Probability Distribution.
It should be able to calculate mean, standard deviation, and create basic plots like those in the classes I linked.
Please assign this issue to me, I am new to open source and would like to contribute
@AmeyaPhadnis-2019H1030012G I'd be glad to assign it to you! Before that, could you tell me a bit about how you plan to approach it ?
Hi @hot9cups. If this does not get assigned, I would like to complete this task. To prepare, my plan is to go through the code for the distribution classes, their respective tests in test.py, documentation for matplotlib, read up on poisson distribution, come up with a numbers_poisson.txt for demo data. For the implementation, I'm going to mimic the implementation of the other distribution classes
@ho-jonathan Since AmeyaPhadnis seems to have deserted us(And they also have request for claims on two other issues so if they come back there's always that), I'm assigning it to you.
That plan sounds perfect! Please go ahead!
@ho-jonathan I was wondering how you're progressing with the PR
@ho-jonathan are you still interested in working on this? I will assume it's a no if you're unable to respond within a week :(
Hi @hot9cups If this does not get assigned, I would like to work on this task too. I can assure you, I can provide you with a errorless PR in a matter of 5 hours. Thankyou =)
@whynesspower Thanks for being interested :)
Well saeyma is already working on it so I'm sorry, it's already been assigned.
Hey @hot9cups, can you tell me how to trigger github actions manually? Right now, it happens once a day (I think) but it's slowing down development. I want to run Python Lint Test.
@saeyma The github actions are just flake8 linting tests plus the unit tests in tests.py.
Ideally, you should be running the tests.py file before making a commit so you can check that the code you added actually works(assuming you added tests for the distribution you're working on) as well as haven't broken any other distributions.
As for the linting tests, you can install flake8 on your computer and could check for linting errors via command line and/or various other editors.
Also, the github actions are supposed to run automatically, but there's a restriction in place for first time contributors.
First time contributors to this repo always need my permission to get the action triggered.
You shouldn't require the permission from your second PR onwards :)