Improve read_data_file() function

Question

Improve read_data_file() function

hot9cups opened this issue 4 years ago · 9 comments

Currently the read_data_file() function looks like this

The limitation of the current code is that it'll only work when the numbers are line separated, ie have one number per line.

This can be improved by letting the user specify the separator, which could be passed as an argument to the function.

errpv78 commented 4 years ago

Yeah sure

Answer 1 · 2020-10-27T05:22:25.000Z

Can you assign this issue to me?

Answer 2 · 2020-10-27T06:20:26.000Z

@errpv78 Sure :)
Before you begin, would you mind describing how you plan to go about it?

Answer 3 · 2020-10-27T06:46:22.000Z

Thanks and sure I would like to discuss my approach. I am planning to accept the separator as a function parameter and keeping \n as default. And reading the whole file as a string and then splitting on the separator. I'll begin with this approach and will see what modifications I can perform and anything else that is required.

Answer 4 · 2020-10-27T06:56:12.000Z

That sounds great. There's one improvement I can think of in that letting the user input files even in other formats like .csv, .xlsx, etc.

We can take up the details later and you can start drafting your PR now :)

Answer 5 · 2020-10-27T07:04:06.000Z

Yeah, sure I'll include that too. Cheers!!

Answer 6 · 2020-10-30T05:11:07.000Z

Great work. Thank you for your contribution :)

Answer 7 · 2020-10-30T13:17:30.000Z

You're welcome and had a good experience working on that. Cheers!!

Answer 8 · 2020-10-30T14:34:53.000Z

@errpv78 :) I Look forward to working with you in the future! If you'd like to connect, you can reach out to me on discord hot9cups#3125 and we can discuss something cool to work on ! Cheers mate!