houdiniproject/houdini

[FEATURE] Increase maintainability by giving variables more meaningful names

thiagolopess opened this issue · 3 comments

Is your feature request related to a problem? Please describe.
Yes. Following clean code guidelines for ruby provided in this repository, it would be nice if some enhancements were made regarding the variables names as shown here, so the code is more readable and less comment dependent, hence making it easier to understand.

For instance, at app/controllers/nonprofits/bank_accounts_controller.rb, some variables with not very meaningful names were declared, making it a little more difficult to maintain if necessary, especially if the code gets old.
image

Describe the solution you'd like
Sweep the controllers folder searching for potential problematic variables and fix them accordingly

Thanks for submitting your first issue to Houdini!

If it makes sense, I'll be taking a look at it

I'm not opposed to it. It's not the biggest priority but it's worth looking at.