Config type positive-number not following naming convention

Question

Config type positive-number not following naming convention

Janfel opened this issue 5 years ago · 3 comments

I noticed that the predefined config type positive-number (introduced in e9b418f) does not follow the snake case naming convention set by string_list (introduced in 3df20f0). Is there a reason for this and, if not, would you accept a refactor for consistency?

Answer 1 · 2019-09-17T09:21:58.000Z

To be clear, this wold be a breaking change, however none of the bundles listed on the wiki page are affected by it and, as this type is not documented, I assume that only few, if any, other bundles use it.

Answer 2 · 2019-09-20T08:07:09.000Z

Good catch, and yes, a PR for this would be appreciated. Not really sure what naming convention should be used, but regardless it makes sense to stick to one.

Answer 3 · 2019-09-21T13:01:40.000Z

Snake case seems to be the default naming convention for everything but command names, does not require quoting table keys in Moonscript and choosing it would only change breadcrumbs.moon. Changing to kebap case would require changing four files and the documented public API. Therefore I don't see any reason to choose kebap case over snake case.