hrbrmstr/docxtractr

Possible to have output as tibble?

benmarwick opened this issue · 2 comments

This is an awesome pkg, and I find assign_colnames useful for all kinds of data input besides docx files.

I wonder if you would consider allowing the tables output by docx_extract_tbl() to be tibbles? For a new data set coming in to my R environment I find it very handy to see the column classes that the tibble print method gives.

Could we change this line to as_tibble(dat) ?

You have tibble in suggests already, so I don't think this will change the dependencies. Just thought I'd ask before making at PR in case you have a good reason not to do this.

in fact, i was quite daft with assign_colnames() as it clobbered input data frame class as well. Things that "shld" return tibbles return tibbles, now and I added some other bits of cleanup I had failed to push earlier. #ty for the suggestion!

Thanks very much! I love the new mcga()! (worth a mention in the NEWS, too, no?). It inspired me to push this little add-in out to GitHub: https://github.com/benmarwick/snakecaser