why mkdirp dependecy?
stefanocudini opened this issue · 9 comments
I would like to include this library in various applications, but this dependency seems to me to make little sense
We could replace https://github.com/http-party/node-portfinder/blame/38cf0185a18c1ecb2c2590ae91f0a251b612ab15/lib/portfinder.js#L328 with the node builtin filesystem module.
That code is for creating sockets.
You'll recognize more pieces of that code here: https://github.com/http-party/node-portfinder/blame/38cf0185a18c1ecb2c2590ae91f0a251b612ab15/lib/portfinder.js#L384
Feel free to peruse the code, it's 11 years old and I didn't write it, not that that really matters at all. Here is the original commit: f1cd7ae
Submit a PR that uses the builtin node js mkdir: https://nodejs.org/api/fs.html#fsmkdirsyncpath-options and I'll merge it :)
Releasing a new version that will have no mkdirp installed, will use node directly, this week.
FYI
Are you looking to replace mkdirp with fs.mkdir and make use of the recursive flag added in v10 LTS (and thus breaking support for anything < 10), or doing the recursion by hand in fs.mkdir?
I'm hoping for a breaking change... v14 is the LTS right now...
mkdirp recursively created directories, so just to clarify @MasterOdin in your comment:
(and thus breaking support for anything < 10), or doing the recursion by hand in fs.mkdir?
we do want to recursively create a folder structure - at least that is how the original code was written, and hence its use of mkdirp, which 11 years ago, was how mkdir -p was popularly done in nodejs.
Let me know if I missed something here, thanks.
see #134 for its removal and use of native node api's for mkdir -p
Closed by #134
I created #135 (as there was no test with the recursive folder creation) to help demonstrate my point where if you wish to support node < 10.12, then you'll need to either use mkdirp or do the recursion yourself as fs.mkdir does not support doing it in those old versions of node, but if you drop the old versions (which I'd argue you should), then fs.mkdir works fine as a replacement.
@stefanocudini - to use this library, ideally wrap it in a cli, or you can also from your shell:
eval("require('./lib/portfinder').getPort({ host: '127.0.0.1', port: '8889'}, (err, port) => { console.log(port); })");